Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (video popup): change button tag with div tag #3121

Merged
merged 5 commits into from
Apr 12, 2024
Merged

fix (video popup): change button tag with div tag #3121

merged 5 commits into from
Apr 12, 2024

Conversation

mxkae
Copy link
Contributor

@mxkae mxkae commented Mar 25, 2024

fixes #3055

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 25, 2024 •
edited
Loading

🤖 Pull request artifacts

file commit
pr3121-stackable-3121-merge.zip 5f86b66

github-actions bot added a commit that referenced this pull request Mar 25, 2024
@github-actions
Upload pr3121-stackable-3121-merge.zip (5e8bd)
b814a2e 
Pull request: #3121
Commit: 5e8bdfb
@github-actions GitHub Actions
Copy link

Try this Pull Request in the WordPress playground: https://playground.wordpress.net/?mode=seamless#{"landingPage":"/wp-admin/post-new.php?post_type=page","preferredVersions":{"php":"latest","wp":"latest"},"steps":[{"step":"login","username":"admin","password":"password"},{"step":"installPlugin","pluginZipFile":{"resource":"url","url":"https://raw.githubusercontent.com/gambitph/Stackable/artifacts/pr3121-stackable-3121-merge.zip"}}]}

github-actions bot added a commit that referenced this pull request Apr 4, 2024
@github-actions
Upload pr3121-stackable-3121-merge.zip (dfc5d)
21483d3 
Pull request: #3121
Commit: dfc5d2c
@bfintal bfintal merged commit 651fa2a into develop Apr 12, 2024
1 of 6 checks passed
@bfintal bfintal deleted the fix/3055-video-popup-button branch April 12, 2024 11:56
github-actions bot added a commit that referenced this pull request Apr 12, 2024
@github-actions
Upload pr3121-stackable-3121-merge.zip (5f86b)
7d4bb0e 
Pull request: #3121
Commit: 5f86b66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfintal bfintal bfintal left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stackable adds a button HTML element when using the video popup, creates a box-shadow when on mouse over
2 participants
@mxkae @bfintal